The FR5 test screen stays green after I remove the read

AdaBell0651 · 22 Feb 2026, 08:16 UTC

Closed
AD
AdaBell0651
Removed the status read from our offline display code. Test still passes. The all-true fake isn't helping.

20 replies

NI
NinaChen1197
Replying to AdaBell0651

That is a useful failure to start with. Can your test require an actual read and check where the displayed value came from, instead of merely checking that the screen is green?

5 points
AD
AdaBell0651
Replying to NinaChen1197

It only checks colour. Initial value is accepted, so no read is needed to satisfy it.

7 points
KA
KaiBrown0889
Replying to AdaBell0651

Start unknown. No observation should not look accepted.

8 points
MI
MinaArcher0424
Replying to AdaBell0651

Check the status and its source together. For our equipment screens I ask for the sample identity and observation time beside the result, because a correct-looking value can still belong to the previous sample. Your offline test can exercise that distinction without a controller.

12 points
NI
NinaChen1197
Replying to MinaArcher0424

Mina, yes, though Ada should first make the missing read fail. Otherwise a larger test can hide the same broken assertion under more setup.

20 points
AD
AdaBell0651
Replying to NinaChen1197

Missing-read case fails now. Fake records calls, and display starts unknown. Next: return shapes, not more green.

13 points
KA
KaiBrown0889
Replying to AdaBell0651

Use the documented interface your adapter actually wraps. Don't invent a convenient response shape.

10 points
YA
YasminAdams0093
Replying to AdaBell0651

Does the fake also reject a method name your real interface doesn't have, or could a typo still get a cheerful answer?

24 points
AD
AdaBell0651
Replying to YasminAdams0093

Typos raise now. Unsupported arguments too. Recorded package documentation supplies the boundary cases; no catch-all true.

23 points
NI
NinaChen1197
Replying to AdaBell0651

Try failure after a valid reading. That's the one I'd worry about as an operator: I have seen it work, then the connection fails, and the old good value sits there looking reassuring.

17 points
MI
MinaArcher0424
Replying to NinaChen1197

And distinguish a communication failure from an actual rejected housing. Both may need attention, but the person handling the housing needs to know which one occurred. Did your previous display make that difference visible?

16 points
AD
AdaBell0651
Replying to MinaArcher0424

No, Mina. Same red state for both. I've split unavailable from inspected reject and retained the reason.

15 points
YA
YasminAdams0093
Replying to NinaChen1197

Has the good-then-failed sequence caught anything else, Ada?

4 points
AD
AdaBell0651
Replying to YasminAdams0093

It left the old sample name beside unavailable. Result cleared, identity didn't. Fixed and added that assertion.

9 points
KA
KaiBrown0889
Replying to AdaBell0651

Nice catch. What does an unreadable result do?

10 points
NI
NinaChen1197
Replying to KaiBrown0889

Kai means a response your adapter can't interpret, I think, rather than a housing the inspection has rejected. Worth giving that its own test input.

7 points
KA
KaiBrown0889
Replying to NinaChen1197

Yes, malformed response. My wording was vague.

7 points
MI
MinaArcher0424
Replying to KaiBrown0889

Thanks for spelling that out, Kai. Include the diagnostic reason without showing the housing as rejected; otherwise the operator may send a perfectly unassessed sample down the reject route.

22 points
AD
AdaBell0651
Replying to MinaArcher0424

Malformed response stays unavailable with a reason. Good/failure/reject, wrong identity and missing-read regressions all pass. Offline display bug closed.

9 points
NI
NinaChen1197
Replying to AdaBell0651

Useful result. Give the bench maintainer those sequences and the package reference for the installed comparison, so they know exactly which behaviours you exercised rather than receiving a screenshot of a happy screen.

6 points

Discussion closed

This discussion is closed to new replies after six months without activity. Last activity: .