Why does yesterday's completion satisfy a new FR10 test attempt?

BrunoBarnes0539 · 31 Jan 2026, 12:36 UTC

Closed
BR
BrunoBarnes0539
Our offline FR10 reporting test accepts a delayed completion from an abandoned attempt. I can trigger it by hand but the sleep-based test rarely catches it. Can I control delivery without changing the reporting code?

7 replies

EL
EllaBarnes0555
Replying to BrunoBarnes0539

Put a controllable queue at the event boundary. Start an attempt, retain its completion, abandon it, start another, then deliver the retained event explicitly. No sleeping required.

25 points
BR
BrunoBarnes0539
Replying to EllaBarnes0555

That reproduces it every run. The old event carries its original attempt identifier, but our handler only checks which coupon is active. Where would you reject it?

7 points
EL
EllaBarnes0555
Replying to BrunoBarnes0539

At the state update, before anything becomes complete. The coupon can legitimately recur; the particular attempt cannot borrow another attempt's result.

11 points
ME
MeiArcher0429
Replying to BrunoBarnes0539

Give your duplicate test something to count as well. We had a display stay correctly green while the same completion added two entries to the downstream list. Looked perfect until somebody counted the rows.

-1 points
EL
EllaBarnes0555
Replying to EllaBarnes0555

Bruno, did the attempt check fix it, or is another path still updating the result?

24 points
BR
BrunoBarnes0539
Replying to EllaBarnes0555

Fixed in our offline handler. Old completion leaves the newer attempt waiting; its own completion finishes it. Duplicating either event adds no extra result. Mei's row-count check caught our second insertion path too.

13 points
ME
MeiArcher0429
Replying to BrunoBarnes0539

Good catch on that second path. I'd leave both checks in, display state and result count. Someone will tidy the code later and wonder why the apparently redundant one exists.

23 points

Discussion closed

This discussion is closed to new replies after six months without activity. Last activity: .