Why does our offline inspection screen pass everything?

AaronAllen0262 · 25 Feb 2026, 12:12 UTC

Reply to discussion
AA
AaronAllen0262
Our offline stand-in returns true, so the inspection screen stays green even when I give it no coupon result at all; with the UR5e bench unavailable, I want to replace that cheerful nonsense with saved application responses, but I don't know which examples would expose a bad parser instead of merely keeping the demonstration running

16 replies

OL
OliverChen1146
Replying to AaronAllen0262

Have you got a saved failure response as well as a success, because I would start by making the screen tell those apart before collecting a museum of edge cases

22 points
AA
AaronAllen0262
Replying to OliverChen1146

Yes, an accepted coupon and a rejected coupon from the same application version; the programmer says the stand-in bypasses the parsing code, which explains a lot

2 points
MI
MinaBennett0772
Replying to AaronAllen0262

Then test through the parser. A mock taking a shortcut around the broken bit is just a second application with better manners.

10 points
CA
CallumChen1143
Replying to AaronAllen0262

Our packing demo once showed the result of the previous carton, so does your rejected response actually change the displayed coupon identity as well as the colour?

0 points
FA
FarahChan1113
Replying to AaronAllen0262

Keep an example with no result too, Aaron, since that was the case that first bothered you.

20 points
AA
AaronAllen0262
Replying to MinaBennett0772

The saved reject exposed it: our wrapper tests whether the response has contents, then treats that as acceptance, without reading the result field; the reject response has contents too, obviously

18 points
OL
OliverChen1146
Replying to AaronAllen0262

Expensive way to ask whether a box contains paper, that

10 points
MI
MinaBennett0772
Replying to AaronAllen0262

What does the corrected code do with an unrecognised result value? Don't let an else branch quietly become another green lamp.

11 points
AA
AaronAllen0262
Replying to MinaBennett0772

It reports an unreadable result and leaves acceptance unset; the programmer added a test with an unrecognised value as well as the captured accept and reject, but has not checked the display identity yet

17 points
CA
CallumChen1143
Replying to AaronAllen0262

Please do the identity check, Aaron, especially if a coupon result can arrive while another coupon is already selected on screen.

19 points
FA
FarahChan1113
Replying to CallumChen1143

Callum, would you include reopening the screen with no new response, so an old colour cannot sneak back in from saved display state?

0 points
CA
CallumChen1143
Replying to FarahChan1113

Yes, that is close to what caught us, though ours happened when changing cartons rather than reopening the screen.

0 points
AA
AaronAllen0262
Replying to CallumChen1143

We added reject_after_accept, empty_response and reopen_without_result to the application tests, plus a response for the wrong coupon; the first three now pass, but the wrong-coupon case revealed that the heading changes before the old result is removed

8 points
MI
MinaBennett0772
Replying to AaronAllen0262

Good find. Does the export have the same old-result problem?

21 points
AA
AaronAllen0262
Replying to MinaBennett0772

The export already used the response's coupon identity correctly; we fixed the display reset and the wrong-coupon test now leaves the selected coupon pending, with the other response listed against its own identity, and all five saved-response cases pass through the normal parser and screen code

7 points
OL
OliverChen1146
Replying to AaronAllen0262

That's a useful bit of work while the bench is unavailable, and considerably more convincing than true with a cheerful face

3 points

Add to the discussion

Welcome to Application Robot

Everyone can read the forum. Sign in or create an account to start a discussion, reply, or upload photos.

Forgot your password?

By creating an account, you agree to our Terms and Conditions and community guidelines. Read our Privacy Policy for how your information is handled.