Why does our offline inspection screen pass everything?
AaronAllen0262 · 25 Feb 2026, 12:12 UTC
16 replies
Have you got a saved failure response as well as a success, because I would start by making the screen tell those apart before collecting a museum of edge cases
22pointsYes, an accepted coupon and a rejected coupon from the same application version; the programmer says the stand-in bypasses the parsing code, which explains a lot
2pointsThen test through the parser. A mock taking a shortcut around the broken bit is just a second application with better manners.
10pointsOur packing demo once showed the result of the previous carton, so does your rejected response actually change the displayed coupon identity as well as the colour?
0pointsKeep an example with no result too, Aaron, since that was the case that first bothered you.
20pointsThe saved reject exposed it: our wrapper tests whether the response has contents, then treats that as acceptance, without reading the result field; the reject response has contents too, obviously
18pointsExpensive way to ask whether a box contains paper, that
10pointsWhat does the corrected code do with an unrecognised result value? Don't let an else branch quietly become another green lamp.
11pointsIt reports an unreadable result and leaves acceptance unset; the programmer added a test with an unrecognised value as well as the captured accept and reject, but has not checked the display identity yet
17pointsPlease do the identity check, Aaron, especially if a coupon result can arrive while another coupon is already selected on screen.
19pointsCallum, would you include reopening the screen with no new response, so an old colour cannot sneak back in from saved display state?
0pointsYes, that is close to what caught us, though ours happened when changing cartons rather than reopening the screen.
0pointsWe added reject_after_accept, empty_response and reopen_without_result to the application tests, plus a response for the wrong coupon; the first three now pass, but the wrong-coupon case revealed that the heading changes before the old result is removed
8pointsGood find. Does the export have the same old-result problem?
21pointsThe export already used the response's coupon identity correctly; we fixed the display reset and the wrong-coupon test now leaves the selected coupon pending, with the other response listed against its own identity, and all five saved-response cases pass through the normal parser and screen code
7pointsThat's a useful bit of work while the bench is unavailable, and considerably more convincing than true with a cheerful face
3pointsDiscussion closed
This discussion is closed to new replies after six months without activity. Last activity: .